[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=133295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-133295
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/18 21:39
Start Date: 09/Aug/18 21:39
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6073:
[BEAM-4176] Validate Runner Tests generalization and enable for local reference
runner
URL: https://github.com/apache/beam/pull/6073#discussion_r209087516
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1394,5 +1420,31 @@ artifactId=${project.name}
args argsNeeded
}
}
+
+
+ /**
***********************************************************************************************/
+
+ // Method to create the PortableValidatesRunnerTask.
+ // The method takes PortableValidatesRunnerConfiguration as parameter.
+ project.ext.createPortableValidatesRunnerTask = {
+ def config = it ? it as PortableValidatesRunnerConfiguration : new
PortableValidatesRunnerConfiguration()
+ def name = config.name
+ def beamTestPipelineOptions = [
+
"--runner=org.apache.beam.runners.reference.testing.TestPortableRunner",
+ "--jobServerDriver=${config.jobServerDriver}",
+ ]
+ if(config.jobServerConfig){
+
beamTestPipelineOptions.add("--jobServerConfig=${config.jobServerConfig}")
+ }
+ project.tasks.create(name: name, type: Test) {
+ group = "Verification"
+ description = "Validates the PortableRunner with JobServer
${config.jobServerDriver}"
+ systemProperty "beamTestPipelineOptions",
JsonOutput.toJson(beamTestPipelineOptions)
+ classpath = config.testClasspathConfiguration
+ testClassesDirs =
project.files(project.project(":beam-sdks-java-core").sourceSets.test.output.classesDirs,
project.project(":beam-runners-core-java").sourceSets.test.output.classesDirs)
Review comment:
I suppose the gradle task will fail verbosely if the down stream project
does not have dependency on :beam-sdks-java-core
The best I can think of at the moment is just document expectation for
:beam-sdks-java-core dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 133295)
Time Spent: 11h 50m (was: 11h 40m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
