[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=150387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150387
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/18 14:01
Start Date: 02/Oct/18 14:01
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6537:
[BEAM-4176] Store and serve termination state after portable job termination
URL: https://github.com/apache/beam/pull/6537#discussion_r221954754
##########
File path:
runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
##########
@@ -35,22 +35,28 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-class JobServicePipelineResult implements PipelineResult {
+class JobServicePipelineResult implements PipelineResult, AutoCloseable {
private static final long POLL_INTERVAL_MS = 10 * 1000;
private static final Logger LOG =
LoggerFactory.getLogger(JobServicePipelineResult.class);
private final ByteString jobId;
private final CloseableResource<JobServiceBlockingStub> jobService;
+ @Nullable
+ private State terminationState;
JobServicePipelineResult(ByteString jobId,
CloseableResource<JobServiceBlockingStub> jobService) {
this.jobId = jobId;
this.jobService = jobService;
+ this.terminationState = null;
}
@Override
public State getState() {
+ if(terminationState != null){
Review comment:
space missing after `if` and `)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 150387)
Time Spent: 24.5h (was: 24h 20m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Attachments: Screen Shot 2018-08-14 at 4.18.31 PM.png, Screen Shot
> 2018-09-03 at 11.07.38 AM.png
>
> Time Spent: 24.5h
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
