[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=150499&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150499
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/18 18:56
Start Date: 02/Oct/18 18:56
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6537:
[BEAM-4176] Store and serve termination state after portable job termination
URL: https://github.com/apache/beam/pull/6537#discussion_r222072211
##########
File path:
runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
##########
@@ -103,11 +112,7 @@ public State waitUntilFinish() {
response = stub.getState(request);
lastState = getJavaState(response.getState());
}
- try {
- jobService.close();
- } catch (Exception e) {
- LOG.warn("Error cleaning up job service", e);
- }
Review comment:
The current behavior of connection cleanup is un-intuitive. The connection
use to get closed only if the user called waitUntillFinish while if user did
not call WUF then the connection is not closed. Hence removing the connection
closing here so that the connection is only closed explicitly in close call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 150499)
Time Spent: 25h 10m (was: 25h)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Attachments: Screen Shot 2018-08-14 at 4.18.31 PM.png, Screen Shot
> 2018-09-03 at 11.07.38 AM.png
>
> Time Spent: 25h 10m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
