[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=150782&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150782
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Oct/18 15:26
Start Date: 03/Oct/18 15:26
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6537:
[BEAM-4176] Store and serve termination state after portable job termination
URL: https://github.com/apache/beam/pull/6537#discussion_r222356166
##########
File path:
runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
##########
@@ -116,6 +121,12 @@ public MetricResults metrics() {
throw new UnsupportedOperationException("Not yet implemented.");
}
+ @Override
+ public void close() throws Exception {
+ // Close the job service.
+ try (CloseableResource<JobServiceBlockingStub> jobService =
this.jobService) {}
Review comment:
A background thread which does the polling might not be desired by the user.
On the other hand, when `waitUntilFinished()` is called polling is explicitly
requested. We would like to do the polling because it helps to find out whether
to close the JobServer connection but I think that needs to be handled in a
different way, e.g. with a registry of some sort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 150782)
Time Spent: 26h (was: 25h 50m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Attachments: Screen Shot 2018-08-14 at 4.18.31 PM.png, Screen Shot
> 2018-09-03 at 11.07.38 AM.png
>
> Time Spent: 26h
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
