[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=150500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150500
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Oct/18 18:58
Start Date: 02/Oct/18 18:58
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6537:
[BEAM-4176] Store and serve termination state after portable job termination
URL: https://github.com/apache/beam/pull/6537#discussion_r222072893
##########
File path:
runners/reference/java/src/main/java/org/apache/beam/runners/reference/JobServicePipelineResult.java
##########
@@ -116,6 +121,12 @@ public MetricResults metrics() {
throw new UnsupportedOperationException("Not yet implemented.");
}
+ @Override
+ public void close() throws Exception {
+ // Close the job service.
+ try (CloseableResource<JobServiceBlockingStub> jobService =
this.jobService) {}
Review comment:
yes, we will need it. Also as the jobServer is not persistent, the
PipelineResult object usability is limited.
One approach can be to just keep on requesting for state after job creation.
Once we reach the termination state then close the connection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 150500)
Time Spent: 25h 20m (was: 25h 10m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Attachments: Screen Shot 2018-08-14 at 4.18.31 PM.png, Screen Shot
> 2018-09-03 at 11.07.38 AM.png
>
> Time Spent: 25h 20m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
