[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=153751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153751
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/18 01:20
Start Date: 12/Oct/18 01:20
Worklog Time Spent: 10m
Work Description: charlesccychen commented on issue #6600: [BEAM-5442]
Store duplicate unknown options in a list argument
URL: https://github.com/apache/beam/pull/6600#issuecomment-429172685
Is there an alternative we can do to this approach of inferring a list from
duplicates / automatically populating these options into the parser? It makes
certain things brittle--for example, every time we try to access such an
option, we now need to branch on whether a possibly-multiply-passed option is
passed once or more than once.
Can we do this parsing at the runner side instead, where instead of
inferring this behavior, we pass a list of unparsed options? In this way, the
runner side could parse these as they wish, and we don't need this "magic"
behavior.
CC: @robertwb @aaltay
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 153751)
Time Spent: 8h 20m (was: 8h 10m)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Fix For: 2.8.0
>
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
