[ 
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=153917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153917
 ]

ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Oct/18 15:36
            Start Date: 12/Oct/18 15:36
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on issue #6600: [BEAM-5442] 
Store duplicate unknown options in a list argument
URL: https://github.com/apache/beam/pull/6600#issuecomment-429367628
 
 
   To clarify again, I believe that with the current approach, a user no longer 
needs to explicitly define a pipeline option to use it--they can just pass it 
(as `--myparam abc`) and it will be "magically" available for use (as 
`options.myparam`).  This is not good for backwards compatibility, since the 
user should not rely on this implementation detail, and it will become 
problematic if we decide to change this after the user starts using it.  I 
would therefore prefer to isolate these options so that they are at least not 
user-visible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 153917)
    Time Spent: 9h 10m  (was: 9h)

> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
>                 Key: BEAM-5442
>                 URL: https://issues.apache.org/jira/browse/BEAM-5442
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core, sdk-py-core
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>              Labels: portability, portability-flink
>             Fix For: 2.8.0
>
>          Time Spent: 9h 10m
>  Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing 
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the 
> PortableRunner. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to