[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=153916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153916
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/18 15:33
Start Date: 12/Oct/18 15:33
Worklog Time Spent: 10m
Work Description: charlesccychen commented on issue #6600: [BEAM-5442]
Store duplicate unknown options in a list argument
URL: https://github.com/apache/beam/pull/6600#issuecomment-429366775
Thanks. My concern wasn't about the runtime cost. It introduces an
inconsistency where single and multiply passed options are treated differently
(and this requires special casing when using the value) and it also promotes
the use of the "magical" behavior as opposed to explicit definition of pipeline
options. We should not have users depend on this, since it would discourage
explicit definition of pipeline options in the user pipeline. I would
therefore suggest passing "unused options" which can be parsed by the runner
using a (potentially runner-specific) explicitly-defined parser. What do you
think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 153916)
Time Spent: 9h (was: 8h 50m)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Fix For: 2.8.0
>
> Time Spent: 9h
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
