[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=153823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153823
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Oct/18 08:35
Start Date: 12/Oct/18 08:35
Worklog Time Spent: 10m
Work Description: mxm commented on issue #6600: [BEAM-5442] Store
duplicate unknown options in a list argument
URL: https://github.com/apache/beam/pull/6600#issuecomment-429249364
@charlesccychen Can you elaborate on what is problematic about this
approach? The parsing is cheap and not different for the other options. We only
parse options which are not recognized by the SDK to pass them on to the
Runner. We don't change any builtin options. Handling list options became a
necessity. If that is somehow problematic, we could also ignore list options
and only allow single value options.
My first approach was to have a "Runner" option which stores options
unrecognized by the SDK, but IMHO it is cleaner to pass them as top-level
options because that is what they are. If we had a separate flag, the Runner
would merge them all together again. Perhaps we could have an "SDK options"
flag.
I'm open to suggestions to improve on the current approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 153823)
Time Spent: 8h 50m (was: 8h 40m)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Fix For: 2.8.0
>
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
