kanterov commented on a change in pull request #11074: Store logical type
values in Row instead of base values
URL: https://github.com/apache/beam/pull/11074#discussion_r389650187
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaCoder.java
##########
@@ -119,27 +86,6 @@ protected SchemaCoder(
return RowCoder.of(schema);
}
- /** Returns the coder used for a given primitive type. */
- public static <T> Coder<T> coderForFieldType(FieldType fieldType) {
Review comment:
I find this was useful to have, and it was public. Instead, I would suggest
`SchemaCoderHelpers` to be package-private, and this method to delegate to
`SchemaCoderHelpers`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
