kanterov commented on a change in pull request #11074: Store logical type
values in Row instead of base values
URL: https://github.com/apache/beam/pull/11074#discussion_r389648327
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Sample.java
##########
@@ -202,10 +202,10 @@ public void populateDisplayData(DisplayData.Builder
builder) {
}
/** A {@link CombineFn} that combines into a {@link List} of up to limit
elements. */
- private static class SampleAnyCombineFn<T> extends CombineFn<T, List<T>,
Iterable<T>> {
+ public static class SampleAnyCombineFn<T> extends CombineFn<T, List<T>,
Iterable<T>> {
Review comment:
nit: doesn't look necessary, we can probably replicate this combiner in
tests, instead of extending public API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
