kanterov commented on a change in pull request #11074: Store logical type
values in Row instead of base values
URL: https://github.com/apache/beam/pull/11074#discussion_r389653458
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/FromRowUsingCreator.java
##########
@@ -126,21 +127,25 @@ public T apply(Row row) {
valueType,
typeFactory);
} else {
- if (type.getTypeName().isLogicalType()
- &&
OneOfType.IDENTIFIER.equals(type.getLogicalType().getIdentifier())) {
+ if (type.isLogicalType(OneOfType.IDENTIFIER)) {
Review comment:
Probably I need to look into the code more. Why is `OneOfType` is a special
case, while there is a generic branch for other logical types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
