kanterov commented on a change in pull request #11074: Store logical type
values in Row instead of base values
URL: https://github.com/apache/beam/pull/11074#discussion_r389645792
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/JavaFieldSchemaTest.java
##########
@@ -592,41 +593,66 @@ public void testEnumFieldToRow() throws
NoSuchSchemaException {
SchemaRegistry registry = SchemaRegistry.createDefault();
Schema schema = registry.getSchema(PojoWithEnum.class);
SchemaTestUtils.assertSchemaEquivalent(POJO_WITH_ENUM_SCHEMA, schema);
- EnumerationType enumerationType =
-
POJO_WITH_ENUM_SCHEMA.getField(0).getType().getLogicalType(EnumerationType.class);
+ EnumerationType enumerationType = ENUMERATION;
+ List<EnumerationType.Value> allColors =
+ Lists.newArrayList(
+ enumerationType.valueOf("RED"),
+ enumerationType.valueOf("GREEN"),
+ enumerationType.valueOf("BLUE"));
Row redRow =
-
Row.withSchema(POJO_WITH_ENUM_SCHEMA).addValue(enumerationType.valueOf("RED")).build();
+ Row.withSchema(POJO_WITH_ENUM_SCHEMA)
+ .addValues(enumerationType.valueOf("RED"), allColors)
+ .build();
Row greenRow =
-
Row.withSchema(POJO_WITH_ENUM_SCHEMA).addValue(enumerationType.valueOf("GREEN")).build();
+ Row.withSchema(POJO_WITH_ENUM_SCHEMA)
+ .addValues(enumerationType.valueOf("GREEN"), allColors)
+ .build();
Row blueRow =
-
Row.withSchema(POJO_WITH_ENUM_SCHEMA).addValue(enumerationType.valueOf("BLUE")).build();
+ Row.withSchema(POJO_WITH_ENUM_SCHEMA)
+ .addValues(enumerationType.valueOf("BLUE"), allColors)
+ .build();
+
+ List<Color> allColorsJava = Lists.newArrayList(Color.RED, Color.GREEN,
Color.BLUE);
SerializableFunction<PojoWithEnum, Row> toRow =
registry.getToRowFunction(PojoWithEnum.class);
- assertEquals(redRow, toRow.apply(new PojoWithEnum(Color.RED)));
- assertEquals(greenRow, toRow.apply(new PojoWithEnum(Color.GREEN)));
- assertEquals(blueRow, toRow.apply(new PojoWithEnum(Color.BLUE)));
+ System.err.println("CONVERTED " + toRow.apply(new PojoWithEnum(Color.RED,
allColorsJava)));
Review comment:
nit: we probably don't want `System.err.println` in tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
