udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes URL: https://github.com/apache/beam/pull/11038#discussion_r393304392
########## File path: sdks/python/mypy.ini ########## @@ -17,16 +17,21 @@ [mypy] python_version = 3.6 +files = apache_beam ignore_missing_imports = true -follow_imports = true -warn_no_return = true no_implicit_optional = true +# warnings: +warn_no_return = true warn_redundant_casts = true warn_unused_ignores = true +# formatting: show_error_codes = true -files = apache_beam color_output = true -# uncomment this to see how close we are to being complete +# required setting for dmypy: +follow_imports = error Review comment: Does this mean having to supply all imported modules on the mypy command line? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
