udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r394029843
##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -244,7 +272,7 @@ def is_bounded(self):
return True
-class RangeTracker(object):
+class RangeTracker(Generic[PositionT]):
Review comment:
I'm not sure. Positions might be opaque byte strings, where splitting
happens externally. This might be important for cross-language transforms.
@lukecwik, @robertwb, @chamikaramj , do you have opinion on RangeTracker
position types? Should they all support the Position protocol (defined above)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
