udim commented on a change in pull request #11038: [BEAM-7746] More typing fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r394057261
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -171,7 +172,7 @@ def get_responses():
self._worker_thread_pool.shutdown()
# get_responses may be blocked on responses.get(), but we need to return
# control to its caller.
- self._responses.put(no_more_work)
+ self._responses.put(no_more_work) # type: ignore[arg-type]
Review comment:
Sounds like a good idea. There are ~20 places in the code that assign
`object()` as value.
One of them is even called `READER_THREAD_IS_DONE_SENTINEL`. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
