#592: Incorrect resolution of absolute hrefs
---------------------------+--------------------------------------
  Reporter:  olemis        |      Owner:  rjollos
      Type:  defect        |     Status:  review
  Priority:  minor         |  Milestone:  Release 7
 Component:  multiproduct  |    Version:
Resolution:                |   Keywords:  global product TracLinks
---------------------------+--------------------------------------

Comment (by rjollos):

 Replying to [comment:9 olemis]:
 > Why not to create a ticket in Trac issue tracker and see what other
 trac-devs have to say about your patch ?

 I've done that in t:#11245.

 > I have no major objections as long as test cases will be satisfied.
 Maybe it's a good idea to solve target issue here and create another
 ticket for such refactoring (enhancement) ?

 Sounds good. As for your patch, I think that I understand it now, and
 everything looks good. I would like to break up the unit test case into
 multiple test cases so that we don't have to setup the object state midway
 through the test case (i.e. `self.product_env._abs_href = None` and `del
 self.product_env.abs_href `), but I'll just go ahead and do that and ask
 for your review after it's committed.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/592#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker

Reply via email to