#592: Incorrect resolution of absolute hrefs
---------------------------+--------------------------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: review
Priority: minor | Milestone: Release 7
Component: multiproduct | Version:
Resolution: | Keywords: global product TracLinks
---------------------------+--------------------------------------
Comment (by olemis):
Replying to [comment:13 rjollos]:
> Replying to [comment:9 olemis]:
> > I got the idea you want to express in your comment , however I'm not
completely sure of all the implications . The duplication of
''_base_url''s proposed in the patch is due to the fact that product
configuration options inherit global values.
[...]
>
> I think we may have gotten crossed here. I'm not suggesting there is
anything wrong with your patch. I'm only suggesting that the patch touches
some code that may have a separate issue.
No problem ... I just tried to say «do not be shy . move on ... but beware
of regressions» ;)
I took the chance to explain why a duplicate `_base_url` attribute is
actually needed beyond double-caching .
> In reviewing the code and trying to understand everything I found what
looks like a "double-caching" situation. So the only changes I propose to
make (in another ticket), have to do with removing the private variables
that perform the same caching that `lazy` provides. I was hoping you could
confirm or deny this based on your review of the `href` and `abs_href`
functions, and your understanding of how `lazy` behaves.
do not be shy . move on ... but beware of regressions
:)
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/592#comment:14>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
