#592: Incorrect resolution of absolute hrefs
---------------------------+--------------------------------------
Reporter: olemis | Owner: rjollos
Type: defect | Status: review
Priority: minor | Milestone: Release 7
Component: multiproduct | Version:
Resolution: | Keywords: global product TracLinks
---------------------------+--------------------------------------
Comment (by rjollos):
Replying to [comment:9 olemis]:
> I got the idea you want to express in your comment , however I'm not
completely sure of all the implications . The duplication of
''_base_url''s proposed in the patch is due to the fact that product
configuration options inherit global values. The issue in situation (2)
listed in ticket description consists in the fact that if global option is
set to a given value then DB configuration objects of all other products
will inherit the very same value unless explicitly updated in a given
product `base_url` configuration option. That's not a good idea since that
leads to some of the errors mentioned in #594 . The way to work around
this consists in reading product option and return its value only if it's
different to global env's.
I think we may have gotten crossed here. I'm not suggesting there is
anything wrong with your patch. I'm only suggesting that the patch touches
some code that may have a separate issue. In reviewing the code and trying
to understand everything I found what looks like a "double-caching"
situation. So the only changes I propose to make (in another ticket), have
to do with removing the private variables that perform the same caching
that `lazy` provides. I was hoping you could confirm or deny this based on
your review of the `href` and `abs_href` functions, and your understanding
of how `lazy` behaves.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/592#comment:13>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
