hangc0276 commented on code in PR #3779:
URL: https://github.com/apache/bookkeeper/pull/3779#discussion_r1110480219
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -675,6 +675,8 @@ protected BookieNode selectRandomFromRack(String netPath,
Set<Node> excludeBooki
}
return bn;
}
+ LOG.warn("Failed to select bookie node from path: {}, leaves: {},
exclude Bookies: {}, ensemble: {}",
Review Comment:
@asafm Good point, thanks for your suggestion. I moved the log out of the
method and put it in the catch block. Please help take a look again, thanks a
lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
