horizonzy commented on code in PR #3779:
URL: https://github.com/apache/bookkeeper/pull/3779#discussion_r1110947302
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -519,9 +519,9 @@ public BookieNode selectFromNetworkLocation(
networkLoc, excludeBookies);
throw e;
}
- LOG.warn("Failed to choose a bookie from {} : "
- + "excluded {}, fallback to choose bookie randomly from
the cluster.",
- networkLoc, excludeBookies);
+ LOG.warn("Failed to choose a bookie from {} : leaves {}, excluded
bookies {}, "
Review Comment:
The `leaves` may confuse the user.
Failed to choose a bookie from {} : leaves -> Failed to choose a bookie from
network location {}, the network location corresponding bookies {}
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -544,6 +544,9 @@ public BookieNode selectFromNetworkLocation(String
networkLoc,
* the whole cluster and exclude the racks specified at
* <tt>excludeRacks</tt>.
*/
+ LOG.warn("Failed to choose a bookie node from {} : leaves {},
exclude Bookies {}, "
Review Comment:
The `leaves` may confuse the user.
Failed to choose a bookie from {} : leaves -> Failed to choose a bookie from
network location {}, the network location corresponding bookies {}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
