asafm commented on code in PR #3779:
URL: https://github.com/apache/bookkeeper/pull/3779#discussion_r1111206968
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -675,6 +675,8 @@ protected BookieNode selectRandomFromRack(String netPath,
Set<Node> excludeBooki
}
return bn;
}
+ LOG.warn("Failed to select bookie node from path: {}, leaves: {},
exclude Bookies: {}, ensemble: {}",
Review Comment:
What do you say about :
> Since there are so many ways to this method to throw an exception, I would
add a reason message at each throw, and include it in the logs printed which
receive it.
Since `selectRandomFromRack` has several ways to fail and throw an
exception, how about we include an error message in the exception and log it as
well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
