asafm commented on code in PR #3779:
URL: https://github.com/apache/bookkeeper/pull/3779#discussion_r1111207291
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##########
@@ -544,6 +545,10 @@ public BookieNode selectFromNetworkLocation(String
networkLoc,
* the whole cluster and exclude the racks specified at
* <tt>excludeRacks</tt>.
*/
+ LOG.warn("Failed to choose a bookie node from network location {},
"
Review Comment:
Don't you think here it is actually an INFO?
What if we have 5 racks. If we failed choosing from same rack (say rack 1)
and we can't choose from rack 2 and 3 since they already have other copies, we
can still choose from rack 4, and it's ok, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
