zabetak commented on a change in pull request #1112: [CALCITE-2930]
FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
IllegalStateException (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1112#discussion_r267224120
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -2380,6 +2381,8 @@ public static boolean classifyFilters(
joinRel.getInputs().get(1).getRowType().getFieldList();
final int nFieldsRight = rightFields.size();
assert nTotalFields == (joinRel instanceof SemiJoin
Review comment:
If I am not mistaken nSysFields is not used anymore and is always zero. If
that's the case can you remove it please. Moreover the assertion looks a bit
weird (plus a bit trivial). If the method cannot treat all kinds of joins then
that should be a precondition with an IllegalArgumentException and not an
assertion. I would be inclined to remove entirely this assertion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
