zabetak commented on a change in pull request #1112: [CALCITE-2930]
FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
IllegalStateException (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1112#discussion_r267576249
##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptUtil.java
##########
@@ -2380,6 +2381,8 @@ public static boolean classifyFilters(
joinRel.getInputs().get(1).getRowType().getFieldList();
final int nFieldsRight = rightFields.size();
assert nTotalFields == (joinRel instanceof SemiJoin
Review comment:
I totally agree that the hierarchy of Correlate, Join, etc., needs to be
redesigned but I don't think this can/should be done as part of this issue.
Regarding the assertion, I think it is a bit misplaced; it verifies how many
fields the join has in relation with its inputs (depending also on the type).
Such an assertion would appear reasonable if it was introduced when the
respective operators are created but not in a method which is a mere consumer
of the operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
