zabetak commented on a change in pull request #1112: [CALCITE-2930]
FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
IllegalStateException (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1112#discussion_r267259337
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/FilterCorrelateRule.java
##########
@@ -86,8 +86,10 @@ public void onMatch(RelOptRuleCall call) {
aboveFilters,
JoinRelType.INNER,
false,
- !corr.getJoinType().toJoinType().generatesNullsOnLeft(),
- !corr.getJoinType().toJoinType().generatesNullsOnRight(),
+ corr.getJoinType().returnsJustFirstInput()
Review comment:
No we are not sure yet adding new types in a public enumerations affects
backward compatibility so I guess it will not happen often. If at some point in
the future somebody does that he will have to consider usecases like this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
