zabetak commented on a change in pull request #1112: [CALCITE-2930]
FilterCorrelateRule on a Correlate with SemiJoinType SEMI (or ANTI) throws
IllegalStateException (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1112#discussion_r267218348
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/FilterCorrelateRule.java
##########
@@ -86,8 +86,10 @@ public void onMatch(RelOptRuleCall call) {
aboveFilters,
JoinRelType.INNER,
false,
- !corr.getJoinType().toJoinType().generatesNullsOnLeft(),
- !corr.getJoinType().toJoinType().generatesNullsOnRight(),
+ corr.getJoinType().returnsJustFirstInput()
Review comment:
Can't this be replaced with `true`? The SemiJoinType can never be RIGHT or
FULL so in any case the filters can be pushed into the left relation because it
never generates nulls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
