rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow
theta joins that have equi conditions to be exec…
URL: https://github.com/apache/calcite/pull/1156#discussion_r283656578
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableJoin.java
##########
@@ -227,6 +223,40 @@ public Result implement(EnumerableRelImplementor
implementor, Prefer pref) {
joinType.generatesNullsOnRight())))).toBlock());
}
+ Expression predicate(EnumerableRelImplementor implementor,
Review comment:
Small detail to keep consistency, I think it would be better to use an
action (a verb) in the method name, e.g. something like `generatePredicate`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
