rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow
theta joins that have equi conditions to be exec…
URL: https://github.com/apache/calcite/pull/1156#discussion_r316608509
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -1054,7 +1054,31 @@ public void close() {
resultSelector,
comparer,
generateNullsOnLeft,
- generateNullsOnRight);
+ generateNullsOnRight, null);
Review comment:
minor: to be consistent style-wise, `null` should be in a new line (same
with `predicate` in line 1081).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
