rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow
theta joins that have equi conditions to be exec…
URL: https://github.com/apache/calcite/pull/1156#discussion_r316607816
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableJoinRule.java
##########
@@ -61,12 +61,29 @@
if (!info.isEqui() && join.getJoinType() != JoinRelType.INNER) {
// EnumerableHashJoin only supports equi-join. We can put a filter on top
// if it is an inner join.
- return EnumerableNestedLoopJoin.create(
- left,
- right,
- join.getCondition(),
- join.getVariablesSet(),
- join.getJoinType());
+ RelNode newRel;
+ //if it has equiKeys ,we can create an EnumerableHashJoin with
Review comment:
Minor detail. Please review style in the comment line: whitespace after '//'
and after comma (not before). Same applies for comment in line 74.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
