rubenada commented on a change in pull request #1156: [CALCITE-2973] Allow
theta joins that have equi conditions to be exec…
URL: https://github.com/apache/calcite/pull/1156#discussion_r283702691
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableJoin.java
##########
@@ -64,27 +77,20 @@ protected EnumerableJoin(
traits,
left,
right,
- condition,
+ equiCondition,
leftKeys,
rightKeys,
variablesSet,
joinType);
- }
-
- @Deprecated // to be removed before 2.0
- protected EnumerableJoin(RelOptCluster cluster, RelTraitSet traits,
- RelNode left, RelNode right, RexNode condition, ImmutableIntList
leftKeys,
- ImmutableIntList rightKeys, JoinRelType joinType,
- Set<String> variablesStopped) throws InvalidRelException {
- this(cluster, traits, left, right, condition, leftKeys, rightKeys,
- CorrelationId.setOf(variablesStopped), joinType);
+ this.remainCondition = remainCondition;
}
/** Creates an EnumerableJoin. */
public static EnumerableJoin create(
RelNode left,
RelNode right,
- RexNode condition,
+ RexNode equiCondition,
+ RexNode remainCondition,
Review comment:
Thanks @LaiZhou , but I was talking about the factory `public static
EnumerableJoin create` method, sorry if I was not clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
