danny0405 commented on a change in pull request #1271: [CALCITE-3112]Support
Window in RelToSqlConverter
URL: https://github.com/apache/calcite/pull/1271#discussion_r294778144
##########
File path:
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
##########
@@ -203,6 +205,30 @@ public Result visit(Project e) {
return builder.result();
}
+ /** @see #dispatch */
+ public Result visit(Window e) {
+ Result x = visitChild(0, e.getInput());
+ Builder builder = x.builder(e);
Review comment:
Do we need to take care of the input for window input ? `x.builder(e)` seems
only work for project input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
