danny0405 commented on a change in pull request #1271: [CALCITE-3112]Support
Window in RelToSqlConverter
URL: https://github.com/apache/calcite/pull/1271#discussion_r305208638
##########
File path:
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
##########
@@ -3472,6 +3542,14 @@ private void checkLiteral2(String expression, String
expected) {
this.config = config;
}
+ /**
+ * Open the test for converting a {@code Window} to sql.
+ */
+ Sql includeWindow(boolean includeWindow) {
+ this.window = includeWindow;
+ return this;
Review comment:
Why we need a flag here, shouldn't support window be a default behavior ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
