julianhyde commented on a change in pull request #1587: [CALCITE-3272] Support
TUMBLE as Table Valued Function including an enumerable implementation,
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r350526695
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlKind.java
##########
@@ -988,17 +988,21 @@
/** The {@code ROW_NUMBER} window function. */
CUME_DIST,
- // Group functions
+ /** The {@code DESCRIPTOR}. */
+ DESCRIPTOR,
- /** The {@code TUMBLE} group function. */
+ /** The {@code TUMBLE_TABLE_FUNCTION}. */
Review comment:
My point was that TUMBLE_TABLE_FUNCTION is not a SQL keyword, so it
shouldn't be "code".
Ideally TUMBLE becomes an ordinary table function. If so, we can stop using
SqlKind.TUMBLE as a special case. If not, that's also fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
