julianhyde commented on a change in pull request #1587: [CALCITE-3272] Support
TUMBLE as Table Valued Function including an enumerable implementation,
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r350527675
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -2455,7 +2455,13 @@ protected void convertCollectionTable(
}
RexNode rexCall = bb.convertExpression(call);
- final List<RelNode> inputs = bb.retrieveCursors();
+ List<RelNode> inputs = new ArrayList<>();
+
+ if (rexCall.getKind() == SqlKind.TUMBLE) {
Review comment:
It's possible that the fix is in `bb.retrieveCursors()`. Also possible, and
in fact better, would be to let Calcite treat `TUMBLE` as an ordinary table
function (in other words, don't check for `SqlKind.TUMBLE`). Then everything
might just work out of the box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
