danny0405 commented on a change in pull request #1587: [CALCITE-3272] Support
TUMBLE as Table Valued Function including an enumerable implementation,
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r358026955
##########
File path:
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
##########
@@ -2285,6 +2285,7 @@ private SqlNode registerFrom(
case VALUES:
case WITH:
case OTHER_FUNCTION:
+ case TUMBLE:
Review comment:
This is not necessary, handle the function like lateral table [1]
[1]
https://github.com/apache/calcite/blob/b93ec5a9edb7459696385e6adad67b92b6d406d7/core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java#L2256
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
