danny0405 commented on a change in pull request #1587: [CALCITE-3272] Support
TUMBLE as Table Valued Function including an enumerable implementation,
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r361452167
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -293,6 +295,8 @@
new HashMap<>();
private final Map<SqlMatchFunction, Supplier<? extends MatchImplementor>>
matchMap =
new HashMap<>();
+ private final Map<SqlOperator, TableValuedFunctionCallImplementor>
tvfImplementorMap =
+ new HashMap<>();
Review comment:
The value type should also be a `Supplier`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
