danny0405 commented on a change in pull request #1587: [CALCITE-3272] Support 
TUMBLE as Table Valued Function including an enumerable implementation, 
stream.iq and DESCRIPTOR
URL: https://github.com/apache/calcite/pull/1587#discussion_r361452818
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
 ##########
 @@ -928,6 +933,10 @@ public MatchImplementor get(final SqlMatchFunction 
function) {
     }
   }
 
+  public TableValuedFunctionCallImplementor getTvfImplementor(final 
SqlOperator operator) {
+    return tvfImplementorMap.get(operator);
 
 Review comment:
   Rename this method to `get` and pass in argument as type 
`SqlWindowTableFunction`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to