rubenada commented on a change in pull request #1937:
URL: https://github.com/apache/calcite/pull/1937#discussion_r415721356



##########
File path: core/src/main/java/org/apache/calcite/sql/SqlCollation.java
##########
@@ -279,4 +281,18 @@ public final String getCollationName() {
   public final SqlCollation.Coercibility getCoercibility() {
     return coercibility;
   }
+
+  /**
+   * @return Comparator to be used, or null if no special comparator is 
required.
+   */
+  public Comparator<String> getComparator() {
+    return null;
+  }
+
+  /**
+   * @return Comparator expression to be used, or null if no special 
comparator is required.
+   */
+  public Expression getComparatorExpression() {

Review comment:
       I agree. I guess to cleanest solution would be having an 
`EnumerableSqlCollation extends SqlCollation` and having this method in there?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to