rubenada commented on a change in pull request #1937:
URL: https://github.com/apache/calcite/pull/1937#discussion_r416157474
##########
File path: core/src/main/java/org/apache/calcite/rex/RexBuilder.java
##########
@@ -919,9 +919,12 @@ protected RexLiteral makeLiteral(
// from the type if necessary.
assert o instanceof NlsString;
NlsString nlsString = (NlsString) o;
- if ((nlsString.getCollation() == null)
- || (nlsString.getCharset() == null)) {
- assert type.getSqlTypeName() == SqlTypeName.CHAR;
+ if (nlsString.getCollation() == null
+ || nlsString.getCharset() == null
+ || !nlsString.getCharset().equals(type.getCharset())
+ || !nlsString.getCollation().equals(type.getCollation())) {
Review comment:
Collator is now extracted from SqlCollation's Locale and strength (so it
implicitly becomes part of the equals / hashCode)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
