rubenada commented on a change in pull request #1937:
URL: https://github.com/apache/calcite/pull/1937#discussion_r416159495
##########
File path: core/src/main/java/org/apache/calcite/runtime/Utilities.java
##########
@@ -212,6 +213,27 @@ public static int compareNullsLast(Comparable v0,
Comparable v1) {
: v0.compareTo(v1);
}
+ public static int compare(Comparable v0, Comparable v1, Comparator
comparator) {
Review comment:
These methods help us to have a compact and homogeneous code in
`PhysTypeImpl.java`, where "complex" comparator expressions can be generated,
combining e.g. numeric keys (without comparator), with String keys (with
comparator).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
