rubenada edited a comment on pull request #1937: URL: https://github.com/apache/calcite/pull/1937#issuecomment-621753623
@zabetak , when you have some time, please take another look at the PR, I have done some rework and refactoring. I am trying to provide a patch with two main goals: - 100% backwards compatibility: by default, everything will be working as before, downstream projects should have no impact because of this change (by default all String comparisons will still be executed via `String#compareTo`, as usual). - Provide an alternative to specify a different comparison behavior, based on a Java Collator (see `JavaCollation` class). The current design fulfills these two requirements, but I must admit I'm not 100% sure if this is the right direction in the long term. So I would accept to annotate `SqlCollation#getCollator` method and the whole `JavaCollation` class as "Experimental" (i.e. subject to change without notice). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
