vlsi commented on a change in pull request #2124:
URL: https://github.com/apache/calcite/pull/2124#discussion_r480276773
##########
File path:
core/src/test/java/org/apache/calcite/rel/rules/DateRangeRulesTest.java
##########
@@ -88,8 +88,7 @@
"UTC",
is("AND(AND(>=($8, 2014-01-01), <($8, 2015-01-01)),"
+ " AND(>=($8, 2014-06-01), <($8, 2014-07-01)))"),
- is("AND(>=($8, 2014-01-01), <($8, 2015-01-01),"
- + " >=($8, 2014-06-01), <($8, 2014-07-01))"));
+ is("SEARCH($8, Sarg[[2014-06-01\u20252014-07-01)])"));
}
Review comment:
I guess the error was Line is longer than [100 characters (found
103)](https://github.com/apache/calcite/runs/1046107924?check_suite_focus=true#step:4:382),
wasn't it?
Then should we split the line like we usually do in that case?
Should we increase the limit to 120 or so chars?
I'm afraid `ascii` in the file makes the code way harder to read and reason
about :((
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
