vlsi commented on a change in pull request #2124:
URL: https://github.com/apache/calcite/pull/2124#discussion_r480285834
##########
File path:
core/src/test/java/org/apache/calcite/rel/rules/DateRangeRulesTest.java
##########
@@ -88,8 +88,7 @@
"UTC",
is("AND(AND(>=($8, 2014-01-01), <($8, 2015-01-01)),"
+ " AND(>=($8, 2014-06-01), <($8, 2014-07-01)))"),
- is("AND(>=($8, 2014-01-01), <($8, 2015-01-01),"
- + " >=($8, 2014-06-01), <($8, 2014-07-01))"));
+ is("SEARCH($8, Sarg[[2014-06-01\u20252014-07-01)])"));
}
Review comment:
I'm afraid the line could easily be `103 characters` as a single glyph
might take multiple code points (Java chars)
https://github.com/apache/calcite/commit/90663bb534e5c36cb3eb3964c90254491edfba0f#diff-4f1866bc93868c9718e968b312ba9422R301
So what do you think of wrapping the line (or increasing the limit)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
