vlsi commented on a change in pull request #2233:
URL: https://github.com/apache/calcite/pull/2233#discussion_r512769428
##########
File path: core/src/main/java/org/apache/calcite/util/Sarg.java
##########
@@ -131,6 +137,18 @@ public StringBuilder printTo(StringBuilder sb,
&& containsNull == ((Sarg) o).containsNull;
}
+ /** Returns whether this Sarg includes all values (including or not including
+ * null). */
Review comment:
Frankly speaking, the wording of `including or not including` is moot.
What does that mean? Does that mean it ignores nulls? Does that mean it
accounts for nulls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
