vlsi commented on a change in pull request #2233:
URL: https://github.com/apache/calcite/pull/2233#discussion_r512771057
##########
File path: core/src/main/java/org/apache/calcite/util/Sarg.java
##########
@@ -111,7 +117,7 @@ public StringBuilder printTo(StringBuilder sb,
RangeSets.forEach(r, printer);
});
if (containsNull) {
- sb.append(", null");
+ sb.append(" OR NULL");
Review comment:
Is there a reason for the change?
It looks like the only place where OR is used in the string representation
of Sarg. Why is OR needed here?
I would prefer to have a consistent delimiter (e.g. comma always) rather
than different delimeters in different places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
