vlsi commented on a change in pull request #2233:
URL: https://github.com/apache/calcite/pull/2233#discussion_r512771208
##########
File path: core/src/main/java/org/apache/calcite/util/Sarg.java
##########
@@ -102,6 +102,12 @@ private Sarg(ImmutableRangeSet<C> rangeSet, boolean
containsNull) {
* with each embedded value. */
public StringBuilder printTo(StringBuilder sb,
BiConsumer<StringBuilder, C> valuePrinter) {
+ if (isAll()) {
+ return sb.append(containsNull ? "Sarg[TRUE]" : "Sarg[NOT NULL]");
+ }
+ if (rangeSet.isEmpty()) {
Review comment:
Should this be `isNone()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
