a-rafay commented on a change in pull request #2211:
URL: https://github.com/apache/calcite/pull/2211#discussion_r520063982
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {
.check();
}
+ /**
+ * Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-4317";>[CALCITE-4317]
+ * RelFieldTrimmer after trimming all the fields in an aggregate
+ * should not return a zero field Aggregate</a>. */
+ @Test void testProjectJoinTransposeRuleOnAggWithNoFieldsWithTrimmer() {
Review comment:
@Aaaaaaron my test case was slightly different but it seems like similar
to CALCITE-4381, i couldn't reproduce the query we had since we do a lot of
transformation before getting to that state so i started off with creating a
RelNode and applying the rule on that. If this patch fixes CALCITE-4381, then
it shouldn't matter what test case we used if the nature of test case is the
same.
You also asked about the progress of this PR. I am just waiting for this to
get reviewed so we can merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
