rubenada commented on a change in pull request #2211:
URL: https://github.com/apache/calcite/pull/2211#discussion_r526689986



##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -6827,6 +6828,62 @@ protected MyProjectRule(Config config) {
         .check();
   }
 
+  /**
+   * Test case for
+   * <a 
href="https://issues.apache.org/jira/browse/CALCITE-4317";>[CALCITE-4317]
+   * RelFieldTrimmer after trimming all the fields in an aggregate
+   * should not return a zero field Aggregate</a>. */
+  @Test void testProjectJoinTransposeRuleOnAggWithNoFieldsWithTrimmer() {

Review comment:
       Would it be possible to have the test defined in terms of SQL:
   ```
   SELECT name FROM (SELECT count(*) cnt_star, count(empno) cnt_en FROM 
sales.emp)
   cross join sales.dept limit 10
   ```
   rather than RelBuilder?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to