rubenada commented on a change in pull request #2211:
URL: https://github.com/apache/calcite/pull/2211#discussion_r526691162



##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelTestBase.java
##########
@@ -263,6 +263,11 @@ Tester withCatalogReaderFactory(
 
     /** Returns a tester that uses a given context. */
     Tester withContext(UnaryOperator<Context> transform);
+
+    /** Trims a RelNode. */
+    default RelNode trimRelNode(RelNode relNode) {
+      return relNode;

Review comment:
       I'm not quite sure about adding this new `trimRelNode` that by default 
does nothing (hence does not trim the input RelNode).
   Are we sure this is the right place for this method?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to